Fixed providers go modules, examples and consistency. #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
bwplotka
force-pushed
the
fixed-log-providers
branch
from
cc4b539
to
0c6fa75
Compare
Codecov Report
@@ Coverage Diff @@
## v2 #292 +/- ##
=======================================
Coverage 84.01% 84.01%
=======================================
Files 30 30
Lines 932 932
=======================================
Hits 783 783
Misses 110 110
Partials 39 39 Continue to review full report at Codecov.
|
|
all addressed @johanbrandhorst (: |
|
Let's address potential comments on next PR. 🤗 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depend on #291
Signed-off-by: Bartlomiej Plotka bwplotka@gmail.com