Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some description of the Makefile in the contributing.md #298

Merged
merged 1 commit into from
Jun 3, 2020

Conversation

yashrsharma44
Copy link
Collaborator

  • Added some description about the other make commands for running formatting and tests.

Signed-off-by: Yash Sharma yashrsharma44@gmail.com

Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@yashrsharma44
Copy link
Collaborator Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2020

Codecov Report

Merging #298 into v2 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               v2     #298   +/-   ##
=======================================
  Coverage   83.58%   83.58%           
=======================================
  Files          30       30           
  Lines         932      932           
=======================================
  Hits          779      779           
  Misses        114      114           
  Partials       39       39           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0e7c73...a79558a. Read the comment docs.

@johanbrandhorst johanbrandhorst merged commit 4664c92 into grpc-ecosystem:v2 Jun 3, 2020
@johanbrandhorst
Copy link
Collaborator

Thanks for your contribution! Could you cherry pick this against the v2 branch?

@yashrsharma44
Copy link
Collaborator Author

I submitted this to the v2 branch, let me cherry pick this to the master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants