Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test certs - cherry-pick PR325 on v2 #331

Merged
merged 3 commits into from
Sep 9, 2020

Conversation

dmitris
Copy link
Contributor

@dmitris dmitris commented Sep 8, 2020

PR copies the changes in #325 onto the v2 branch. See issue #324 for background.

Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait a sec, shouldn't this be deleting the existing certs too?

@dmitris
Copy link
Contributor Author

dmitris commented Sep 9, 2020

Wait a sec, shouldn't this be deleting the existing certs too?

done in 1b508da

@codecov-commenter
Copy link

Codecov Report

Merging #331 into v2 will decrease coverage by 6.09%.
The diff coverage is 69.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v2     #331      +/-   ##
==========================================
- Coverage   83.58%   77.48%   -6.10%     
==========================================
  Files          30       30              
  Lines         932      924       -8     
==========================================
- Hits          779      716      -63     
- Misses        114      163      +49     
- Partials       39       45       +6     
Impacted Files Coverage Δ
chain.go 0.00% <ø> (-90.91%) ⬇️
interceptors/tags/fieldextractor.go 84.84% <ø> (-0.45%) ⬇️
interceptors/logging/payload.go 83.07% <50.00%> (+0.46%) ⬆️
interceptors/retry/retry.go 69.66% <72.72%> (-6.59%) ⬇️
wrappers.go 66.66% <0.00%> (-33.34%) ⬇️
interceptors/retry/options.go 73.17% <0.00%> (-7.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d07eb4f...538dc63. Read the comment docs.

@johanbrandhorst johanbrandhorst merged commit aef62a9 into grpc-ecosystem:v2 Sep 9, 2020
@johanbrandhorst
Copy link
Collaborator

Thanks for your contribution!

@dmitris dmitris deleted the issue324-v2 branch September 9, 2020 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants