Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove 1.12.x from build config for consistency with master #337

Merged
merged 2 commits into from
Sep 10, 2020

Conversation

dmitris
Copy link
Contributor

@dmitris dmitris commented Sep 9, 2020

Co-authored-by: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>
@johanbrandhorst
Copy link
Collaborator

Flaky logging test again

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2020

Codecov Report

Merging #337 into v2 will decrease coverage by 6.09%.
The diff coverage is 69.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v2     #337      +/-   ##
==========================================
- Coverage   83.58%   77.48%   -6.10%     
==========================================
  Files          30       30              
  Lines         932      924       -8     
==========================================
- Hits          779      716      -63     
- Misses        114      163      +49     
- Partials       39       45       +6     
Impacted Files Coverage Δ
chain.go 0.00% <ø> (-90.91%) ⬇️
interceptors/tags/fieldextractor.go 84.84% <ø> (-0.45%) ⬇️
interceptors/logging/payload.go 83.07% <50.00%> (+0.46%) ⬆️
interceptors/retry/retry.go 69.66% <72.72%> (-6.59%) ⬇️
wrappers.go 66.66% <0.00%> (-33.34%) ⬇️
interceptors/retry/options.go 73.17% <0.00%> (-7.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aef62a9...474b215. Read the comment docs.

@johanbrandhorst johanbrandhorst merged commit 88c8444 into grpc-ecosystem:v2 Sep 10, 2020
@johanbrandhorst
Copy link
Collaborator

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants