improve v2 rate-limiter

[MalloZup]

Descriptions:

This PR improve the rate-limit interceptor changing interface.

Links:

This PR is follow-up of discussion at thanos-io/thanos#3654

[google-cla]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[MalloZup]

@googlebot I signed it!

🏭

[codecov-io]

Codecov Report

Merging #380 (6bfe427) into v2 (a79558a) will decrease coverage by 19.36%.
The diff coverage is 46.37%.

@@             Coverage Diff             @@
##               v2     #380       +/-   ##
===========================================
- Coverage   83.58%   64.21%   -19.37%     
===========================================
  Files          30       34        +4     
  Lines         932      897       -35     
===========================================
- Hits          779      576      -203     
- Misses        114      265      +151     
- Partials       39       56       +17     

Impacted Files	Coverage Δ
chain.go	0.00% <ø> (-90.91%)	⬇️
grpctesting/interceptor_suite.go	0.00% <0.00%> (ø)
interceptors/ratelimit/ratelimit.go	50.00% <0.00%> (-50.00%)	⬇️
interceptors/tags/fieldextractor.go	13.79% <0.00%> (-71.51%)	⬇️
grpctesting/pingservice.go	52.63% <20.00%> (ø)
interceptors/retry/retry.go	66.66% <70.00%> (-9.58%)	⬇️
interceptors/skip/interceptor.go	71.42% <71.42%> (ø)
interceptors/logging/interceptors.go	100.00% <100.00%> (ø)
interceptors/logging/logging.go	61.53% <100.00%> (-6.21%)	⬇️
interceptors/logging/payload.go	67.18% <100.00%> (-15.43%)	⬇️
... and 36 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08b17eb...6bfe427. Read the comment docs.

[bwplotka]

LGTM, just some thoughts. Hope this makes sense (:

[bwplotka]

Let me know when it's good for another review 🤗

Fixes #351

[MalloZup]

@bwplotka yop I will work this week. thx for feedback. I own you a cake or something 😁

[MalloZup]

@bwplotka I do have reworked a bit the PR with providers.

A part of the conflict file, I do have some doubts. I would appreciated if you have any feedback.

when Running go test locally I do have:
go test

# github.com/grpc-ecosystem/go-grpc-middleware/providers/tockenbucket/v2 [github.com/grpc-ecosystem/go-grpc-middleware/providers/tockenbucket/v2.test]
./examples_test.go:27:41: cannot use limiter (type TockenBucketInterceptor) as type "github.com/grpc-ecosystem/go-grpc-middleware/v2/interceptors/ratelimit".Limiter in argument to "github.com/grpc-ecosystem/go-grpc-middleware/v2/interceptors/ratelimit".UnaryServerInterceptor:
	TockenBucketInterceptor does not implement "github.com/grpc-ecosystem/go-grpc-middleware/v2/interceptors/ratelimit".Limiter (wrong type for Limit method)
		have Limit(context.Context) error
		want Limit() bool
./examples_test.go:30:41: cannot use limiter (type TockenBucketInterceptor) as type "github.com/grpc-ecosystem/go-grpc-middleware/v2/interceptors/ratelimit".Limiter in argument to "github.com/grpc-ecosystem/go-grpc-middleware/v2/interceptors/ratelimit".UnaryServerInterceptor:
	TockenBucketInterceptor does not implement "github.com/grpc-ecosystem/go-grpc-middleware/v2/interceptors/ratelimit".Limiter (wrong type for Limit method)
		have Limit(context.Context) error
		want Limit() bool
./examples_test.go:30:41: cannot use "github.com/grpc-ecosystem/go-grpc-middleware/v2/interceptors/ratelimit".UnaryServerInterceptor(limiter) (type grpc.UnaryServerInterceptor) as type grpc.StreamServerInterceptor in argument to middleware.WithStreamServerChain
FAIL	github.com/grpc-ecosystem/go-grpc-middleware/providers/tockenbucket/v2 [build failed]

I can't follow-up this error since I do have changed the interface to accept error. 🤔

Right now I don't know if the issue is cause because of some golang modules/import messiness or some other reason.. Will check more in details but if you have any hint/lights would be great ❤️

[bwplotka]

Yes. This is major problem with multi modules.

you need to play with replace to make sure it works for you locally.

But ideal flow is:

1. Change interface first. Merge PR to v2
2. Make a PR to add provider on top of new interface. Make sure to update code dep to latest.

Done (:

[MalloZup]

@bwplotka thx for confirmation, will play with that

[MalloZup]

@bwplotka take look on this. I have splitted the PR in 2 parts.

The 1st part , (this here) will just implement the error part.

The 2nd part PR follow-up will base on this and implement what I was doing previously

TIA 🌻

[bwplotka]

Solid.

Lgtm! Let's fix comment if you want (:

[MalloZup]

@bwplotka ok I missed the comment. should be fine now

[MalloZup]

thx @bwplotka will follow-up with 2nd ❤️