Moved to buf; Added buf lint; Fixed ping service to match standards; … #383
Conversation
bwplotka
force-pushed
the
update-proto-yash
branch
3 times, most recently
from
3c95098
to
a4f5db6
Compare
bwplotka
force-pushed
the
update-proto-yash
branch
2 times, most recently
from
e83983b
to
49fc59c
Compare
bwplotka
force-pushed
the
buf
branch
3 times, most recently
from
7ff2f54
to
f8379a9
Compare
Codecov Report
@@ Coverage Diff @@
## v2 #383 +/- ##
===========================================
- Coverage 83.58% 56.09% -27.49%
===========================================
Files 30 37 +7
Lines 932 1321 +389
===========================================
- Hits 779 741 -38
- Misses 114 511 +397
- Partials 39 69 +30
Continue to review full report at Codecov.
|
| proto: ## Generate testing protobufs | ||
| proto: $(BUF) $(PROTOC_GEN_GO) $(PROTOC_GEN_GO_GRPC) $(PROTO_TEST_DIR)/test.proto |
There was a problem hiding this comment.
Should we have two targets name proto? I'm not familiar with this Makefile pattern, if it is one.
There was a problem hiding this comment.
I can see this being confusing, but it's totally ok. It's to ensure make help works (and shows this command)
| @PATH=$(GOBIN):$(TMP_GOPATH) $(BUF) protoc \ | ||
| -I $(PROTO_TEST_DIR) \ | ||
| --go_out=$(PROTO_TEST_DIR)/../ \ | ||
| --go-grpc_out=$(PROTO_TEST_DIR)/../ \ | ||
| $(PROTO_TEST_DIR)/*.proto |
There was a problem hiding this comment.
This is awesome, next step would be to just use buf generate: https://docs.buf.build/tour-6/. If you're feeling keen it should be possible to do here already with buf.gen.yaml:
version: v1beta1
plugins:
- name: go
out: testing/testpb/v1
- name: go-grpc
out: testing/testpb/v1You may want opt: paths=source_relative if the files aren't going in the right place.
There was a problem hiding this comment.
uuu nice, let's try it (or in sep PR)
| @@ -0,0 +1,68 @@ | |||
| syntax = "proto3"; | |||
|
|
|||
| package testing.testpb.v1; | |||
| @@ -23,6 +23,12 @@ $(BINGO): $(BINGO_DIR)/bingo.mod | |||
| @echo "(re)installing $(GOBIN)/bingo-v0.3.0" | |||
| @cd $(BINGO_DIR) && $(GO) build -mod=mod -modfile=bingo.mod -o=$(GOBIN)/bingo-v0.3.0 "github.com/bwplotka/bingo" | |||
|
|
|||
| BUF := $(GOBIN)/buf-v0.35.1 | |||
There was a problem hiding this comment.
Why are we adding buf dependency? Wanted to know for info purpose 😛
There was a problem hiding this comment.
Because we use now buf as a tool! (:
|
Look like this is ok to be merged (: Let's make sure we merge after #321 is approved |
bwplotka
force-pushed
the
update-proto-yash
branch
from
55f20ac
to
582d3a5
Compare
…Moved auth to interceptors. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
|
Rebased, rdy to merge (: |
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
…Moved auth to interceptors.
Chained with #321
Signed-off-by: Bartlomiej Plotka bwplotka@gmail.com