-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove backoffutils and added the files to retry package #390
Remove backoffutils and added the files to retry package #390
Conversation
a1d8500
to
27dddb0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet! Thank you! LGTM, just minor nit.
Codecov Report
@@ Coverage Diff @@
## v2 #390 +/- ##
===========================================
- Coverage 83.58% 55.74% -27.84%
===========================================
Files 30 36 +6
Lines 932 1322 +390
===========================================
- Hits 779 737 -42
- Misses 114 514 +400
- Partials 39 71 +32
Continue to review full report at Codecov.
|
Can we get this merged? cc @bwplotka |
825f32f
to
1c5eece
Compare
Codecov Report
@@ Coverage Diff @@
## v2 #390 +/- ##
===========================================
- Coverage 84.01% 57.94% -26.07%
===========================================
Files 30 38 +8
Lines 932 1674 +742
===========================================
+ Hits 783 970 +187
- Misses 110 632 +522
- Partials 39 72 +33
Continue to review full report at Codecov.
|
Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
1c5eece
to
724f3d7
Compare
Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
724f3d7
to
ed90edd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, small suggestion about the new methods.
Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
a3315b3
to
4873611
Compare
Fixes #388