Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove backoffutils and added the files to retry package #390

Merged
merged 5 commits into from
Aug 3, 2021

Conversation

yashrsharma44
Copy link
Collaborator

Fixes #388

Copy link
Collaborator

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! Thank you! LGTM, just minor nit.

interceptors/retry/examples_test.go Outdated Show resolved Hide resolved
interceptors/retry/examples_test.go Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Jan 30, 2021

Codecov Report

Merging #390 (825f32f) into v2 (a79558a) will decrease coverage by 27.83%.
The diff coverage is 37.59%.

Impacted file tree graph

@@             Coverage Diff             @@
##               v2     #390       +/-   ##
===========================================
- Coverage   83.58%   55.74%   -27.84%     
===========================================
  Files          30       36        +6     
  Lines         932     1322      +390     
===========================================
- Hits          779      737       -42     
- Misses        114      514      +400     
- Partials       39       71       +32     
Impacted Files Coverage Δ
chain.go 0.00% <ø> (-90.91%) ⬇️
interceptors/auth/auth.go 100.00% <ø> (ø)
interceptors/auth/metadata.go 100.00% <ø> (ø)
interceptors/ratelimit/ratelimit.go 50.00% <0.00%> (-50.00%) ⬇️
interceptors/tags/fieldextractor.go 13.79% <0.00%> (-71.51%) ⬇️
testing/testpb/interceptor_suite.go 0.00% <0.00%> (ø)
testing/testpb/test.manual_extractfields.pb.go 0.00% <0.00%> (ø)
testing/testpb/test.manual_validator.pb.go 0.00% <0.00%> (ø)
testing/testpb/test.pb.go 36.92% <36.92%> (ø)
interceptors/logging/payload.go 67.18% <42.30%> (-15.43%) ⬇️
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 215af81...825f32f. Read the comment docs.

@yashrsharma44
Copy link
Collaborator Author

Can we get this merged? cc @bwplotka

@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2021

Codecov Report

Merging #390 (f378920) into v2 (6e2c2ac) will decrease coverage by 26.06%.
The diff coverage is 42.69%.

❗ Current head f378920 differs from pull request most recent head 4873611. Consider uploading reports for the commit 4873611 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##               v2     #390       +/-   ##
===========================================
- Coverage   84.01%   57.94%   -26.07%     
===========================================
  Files          30       38        +8     
  Lines         932     1674      +742     
===========================================
+ Hits          783      970      +187     
- Misses        110      632      +522     
- Partials       39       72       +33     
Impacted Files Coverage Δ
chain.go 0.00% <ø> (-90.91%) ⬇️
interceptors/auth/auth.go 100.00% <ø> (ø)
interceptors/auth/metadata.go 100.00% <ø> (ø)
interceptors/logging/options.go 82.85% <0.00%> (-7.77%) ⬇️
interceptors/ratelimit/ratelimit.go 60.00% <0.00%> (-40.00%) ⬇️
interceptors/recovery/options.go 78.57% <ø> (ø)
interceptors/tags/context.go 64.00% <ø> (ø)
interceptors/tags/fieldextractor.go 15.15% <0.00%> (-70.15%) ⬇️
interceptors/tags/interceptors.go 95.65% <ø> (ø)
interceptors/tags/options.go 100.00% <ø> (ø)
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc87da6...4873611. Read the comment docs.

Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small suggestion about the new methods.

interceptors/retry/backoff.go Outdated Show resolved Hide resolved
Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants