Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup v2 with some updates #419

Merged
merged 8 commits into from
Jul 10, 2021
Merged

Conversation

yashrsharma44
Copy link
Collaborator

@yashrsharma44 yashrsharma44 commented Apr 26, 2021

Cleanup some leftover errchecks and updated bunch of dependencies required
Also renamed tocken to token for providers/tokenbucket

Signed-off-by: Yash Sharma yashrsharma44@gmail.com

cc @bwplotka @johanbrandhorst

Copy link
Collaborator

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks!

interceptors/auth/examples_test.go Outdated Show resolved Hide resolved
interceptors/auth/examples_test.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2021

Codecov Report

Merging #419 (41f6361) into v2 (a79558a) will decrease coverage by 27.56%.
The diff coverage is 40.60%.

Impacted file tree graph

@@             Coverage Diff             @@
##               v2     #419       +/-   ##
===========================================
- Coverage   83.58%   56.01%   -27.57%     
===========================================
  Files          30       38        +8     
  Lines         932     1346      +414     
===========================================
- Hits          779      754       -25     
- Misses        114      520      +406     
- Partials       39       72       +33     
Impacted Files Coverage Δ
chain.go 0.00% <ø> (-90.91%) ⬇️
interceptors/auth/auth.go 100.00% <ø> (ø)
interceptors/auth/metadata.go 100.00% <ø> (ø)
interceptors/logging/options.go 82.60% <0.00%> (-8.02%) ⬇️
interceptors/ratelimit/ratelimit.go 50.00% <0.00%> (-50.00%) ⬇️
interceptors/recovery/interceptors.go 100.00% <ø> (ø)
interceptors/recovery/options.go 80.00% <ø> (+1.42%) ⬆️
interceptors/retry/backoff.go 50.00% <ø> (ø)
interceptors/tags/context.go 55.55% <ø> (-8.45%) ⬇️
interceptors/tags/fieldextractor.go 13.79% <0.00%> (-71.51%) ⬇️
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cdca41...41f6361. Read the comment docs.

@google-cla
Copy link

google-cla bot commented Jul 9, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Jul 9, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@yashrsharma44 yashrsharma44 force-pushed the update-grpc branch 2 times, most recently from fec8696 to 5ff5a6b Compare July 9, 2021 10:58
Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
…m grpc examples package

Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
Copy link
Collaborator

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thank you!

@bwplotka bwplotka merged commit 709d415 into grpc-ecosystem:v2 Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants