Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed misleading comments in the interceptor file #424

Merged
merged 4 commits into from
May 27, 2021
Merged

Fixed misleading comments in the interceptor file #424

merged 4 commits into from
May 27, 2021

Conversation

iamrajiv
Copy link
Contributor

Fixes: #378

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2021

Codecov Report

Merging #424 (e7cf566) into v2 (a79558a) will decrease coverage by 27.56%.
The diff coverage is 84.48%.

Impacted file tree graph

@@             Coverage Diff             @@
##               v2     #424       +/-   ##
===========================================
- Coverage   83.58%   56.01%   -27.57%     
===========================================
  Files          30       38        +8     
  Lines         932     1346      +414     
===========================================
- Hits          779      754       -25     
- Misses        114      520      +406     
- Partials       39       72       +33     
Impacted Files Coverage Δ
chain.go 0.00% <ø> (-90.91%) ⬇️
interceptors/client.go 82.85% <ø> (-0.93%) ⬇️
interceptors/ratelimit/ratelimit.go 50.00% <0.00%> (-50.00%) ⬇️
interceptors/server.go 85.71% <ø> (+0.42%) ⬆️
interceptors/tags/fieldextractor.go 13.79% <0.00%> (-71.51%) ⬇️
interceptors/retry/retry.go 66.87% <70.00%> (-9.37%) ⬇️
interceptors/logging/interceptors.go 96.15% <93.75%> (-3.85%) ⬇️
interceptors/logging/logging.go 61.53% <100.00%> (-6.21%) ⬇️
interceptors/logging/payload.go 67.18% <100.00%> (-15.43%) ⬇️
interceptors/tracing/id_extract.go 76.92% <100.00%> (-8.27%) ⬇️
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f6bf00...e7cf566. Read the comment docs.

Copy link
Collaborator

@yashrsharma44 yashrsharma44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, since it's a small change and we can merge this.

cc @johanbrandhorst

@johanbrandhorst johanbrandhorst merged commit f6fb287 into grpc-ecosystem:v2 May 27, 2021
@johanbrandhorst
Copy link
Collaborator

Thanks for your contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants