-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2: Add support for the phuslog logging provider #425
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
@googlebot I fixed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for the logging behavior when using an unknown log level, this LGTM.
fallback to error when no level is detected. Add unknown level With to log and log error message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## v2 #425 +/- ##
===========================================
- Coverage 83.58% 56.01% -27.57%
===========================================
Files 30 38 +8
Lines 932 1346 +414
===========================================
- Hits 779 754 -25
- Misses 114 520 +406
- Partials 39 72 +33
Continue to review full report at Codecov.
|
Integrates phuslog into go-grpc-middleware/providers.
I welcome all feedback!