Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2: Add support for the phuslog logging provider #425

Merged
merged 2 commits into from
Jun 19, 2021

Conversation

ogimenezb
Copy link
Contributor

Integrates phuslog into go-grpc-middleware/providers.

I welcome all feedback!

@google-cla
Copy link

google-cla bot commented Jun 14, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@ogimenezb
Copy link
Contributor Author

@googlebot I fixed it.

Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the logging behavior when using an unknown log level, this LGTM.

providers/phuslog/logger.go Outdated Show resolved Hide resolved
fallback to error when no level is detected.
Add unknown level With to log and log error message
Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Jun 19, 2021

Codecov Report

Merging #425 (ceaff62) into v2 (a79558a) will decrease coverage by 27.56%.
The diff coverage is 40.60%.

Impacted file tree graph

@@             Coverage Diff             @@
##               v2     #425       +/-   ##
===========================================
- Coverage   83.58%   56.01%   -27.57%     
===========================================
  Files          30       38        +8     
  Lines         932     1346      +414     
===========================================
- Hits          779      754       -25     
- Misses        114      520      +406     
- Partials       39       72       +33     
Impacted Files Coverage Δ
chain.go 0.00% <ø> (-90.91%) ⬇️
interceptors/auth/auth.go 100.00% <ø> (ø)
interceptors/auth/metadata.go 100.00% <ø> (ø)
interceptors/logging/options.go 82.60% <0.00%> (-8.02%) ⬇️
interceptors/ratelimit/ratelimit.go 50.00% <0.00%> (-50.00%) ⬇️
interceptors/tags/fieldextractor.go 13.79% <0.00%> (-71.51%) ⬇️
testing/testpb/interceptor_suite.go 0.00% <0.00%> (ø)
testing/testpb/test.manual_extractfields.pb.go 0.00% <0.00%> (ø)
testing/testpb/test.manual_validator.pb.go 0.00% <0.00%> (ø)
testing/testpb/test.pb.go 36.92% <36.92%> (ø)
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6fb287...ceaff62. Read the comment docs.

@johanbrandhorst johanbrandhorst merged commit 0c113ab into grpc-ecosystem:v2 Jun 19, 2021
@ogimenezb ogimenezb deleted the phuslog branch July 11, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants