v2:providers/zap: fix caller annotation #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Logger.Log` calls a zap's log function inside of this function. As a result, caller annotations always point `logger.go`. This commit adds caller skip so that each log message has the correct annotation.
Codecov Report
@@ Coverage Diff @@
## v2 #432 +/- ##
===========================================
- Coverage 83.58% 56.01% -27.57%
===========================================
Files 30 38 +8
Lines 932 1346 +414
===========================================
- Hits 779 754 -25
- Misses 114 520 +406
- Partials 39 72 +33
Continue to review full report at Codecov.
|
|
Thanks for your contribution! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logger.Logcalls a zap's log function inside of this function. As a result, caller annotations always pointzap/logger.go. This commit adds caller skip so that each log message has the correct annotation.