Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openmetrics: forward server context #434

Merged

Conversation

amenzhinsky
Copy link
Contributor

Fixes #433

Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that seems like a reasonable fix!

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2021

Codecov Report

Merging #434 (de0c9c0) into v2 (6e2c2ac) will decrease coverage by 26.15%.
The diff coverage is 40.31%.

Impacted file tree graph

@@             Coverage Diff             @@
##               v2     #434       +/-   ##
===========================================
- Coverage   84.01%   57.86%   -26.16%     
===========================================
  Files          30       38        +8     
  Lines         932     1647      +715     
===========================================
+ Hits          783      953      +170     
- Misses        110      622      +512     
- Partials       39       72       +33     
Impacted Files Coverage Δ
chain.go 0.00% <ø> (-90.91%) ⬇️
interceptors/auth/auth.go 100.00% <ø> (ø)
interceptors/auth/metadata.go 100.00% <ø> (ø)
interceptors/tags/fieldextractor.go 15.15% <0.00%> (-70.15%) ⬇️
testing/testpb/interceptor_suite.go 0.00% <0.00%> (ø)
testing/testpb/test.manual_extractfields.pb.go 0.00% <0.00%> (ø)
testing/testpb/test.manual_validator.pb.go 0.00% <0.00%> (ø)
testing/testpb/test.pb.go 35.17% <35.17%> (ø)
interceptors/logging/options.go 82.85% <50.00%> (-7.77%) ⬇️
interceptors/reporter.go 55.55% <50.00%> (-6.95%) ⬇️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 028d350...de0c9c0. Read the comment docs.

@johanbrandhorst johanbrandhorst merged commit 49d9c0d into grpc-ecosystem:v2 Jul 10, 2021
@johanbrandhorst
Copy link
Collaborator

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants