Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove opentracing from go.mod #477

Merged
merged 1 commit into from
Dec 2, 2021
Merged

Conversation

jpkrohling
Copy link
Contributor

The PR #394 removed the opentracing interceptor, but missed cleaning it up from the go.mod.

The next step after this PR is to change the child modules to depend on the latest version, which should remove opentracing from their go.sum's.

Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@jpkrohling jpkrohling closed this Dec 2, 2021
@jpkrohling jpkrohling reopened this Dec 2, 2021
@jpkrohling
Copy link
Contributor Author

I just signed the CLA, would someone please trigger the check again?

@codecov-commenter
Copy link

Codecov Report

Merging #477 (8e96d1d) into v2 (6e2c2ac) will decrease coverage by 26.43%.
The diff coverage is 48.07%.

Impacted file tree graph

@@             Coverage Diff             @@
##               v2     #477       +/-   ##
===========================================
- Coverage   84.01%   57.58%   -26.44%     
===========================================
  Files          30       28        -2     
  Lines         932     1530      +598     
===========================================
+ Hits          783      881       +98     
- Misses        110      586      +476     
- Partials       39       63       +24     
Impacted Files Coverage Δ
chain.go 0.00% <ø> (-90.91%) ⬇️
interceptors/auth/auth.go 100.00% <ø> (ø)
interceptors/auth/metadata.go 100.00% <ø> (ø)
interceptors/ratelimit/ratelimit.go 60.00% <0.00%> (-40.00%) ⬇️
interceptors/recovery/options.go 78.57% <ø> (ø)
testing/testpb/interceptor_suite.go 0.00% <0.00%> (ø)
testing/testpb/test.manual_validator.pb.go 0.00% <0.00%> (ø)
util/backoffutils/backoff.go 60.00% <ø> (ø)
util/metautils/single_key.go 60.00% <ø> (ø)
wrappers.go 66.66% <ø> (-33.34%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd1540e...8e96d1d. Read the comment docs.

@bwplotka
Copy link
Collaborator

bwplotka commented Dec 2, 2021

Thanks, amazing!

Copy link
Collaborator

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants