Update provider/kit #490
Merged
Update provider/kit #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kakkoyun
approved these changes
Apr 6, 2022
|
Hm, not sure what you mean on those:
🙃 |
|
Plus linter is failing |
|
I'm not sure if I correctly removed the |
|
I don't know, I would need to look into the details. This PR looks like a good direction at least 🙃 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were incompatibilities when requiring the latest commit for the main module.
Hence I've added the
replace github.com/grpc-ecosystem/go-grpc-middleware/v2 => ../..similar to what the provider/openmetrics does.
Now the only problem is that I'm not 100% sure how the removal of the tags package is supposed to work here. Additionally, the
payloadDeciderneeds to be fixed too. I wasn't able to find exactly which type implements that./cc @bwplotka