Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opentracing provider #492

Merged
merged 4 commits into from
May 5, 2022
Merged

Conversation

XSAM
Copy link
Contributor

@XSAM XSAM commented May 5, 2022

Split from #312.

@bwplotka @yashrsharma44 PTAL

@codecov-commenter
Copy link

codecov-commenter commented May 5, 2022

Codecov Report

Merging #492 (90be9c6) into v2 (6e2c2ac) will decrease coverage by 25.52%.
The diff coverage is 50.46%.

❗ Current head 90be9c6 differs from pull request most recent head 75eeeba. Consider uploading reports for the commit 75eeeba to get more accurate results

@@             Coverage Diff             @@
##               v2     #492       +/-   ##
===========================================
- Coverage   84.01%   58.48%   -25.53%     
===========================================
  Files          30       30               
  Lines         932     1573      +641     
===========================================
+ Hits          783      920      +137     
- Misses        110      590      +480     
- Partials       39       63       +24     
Impacted Files Coverage Δ
chain.go 0.00% <ø> (-90.91%) ⬇️
interceptors/auth/auth.go 100.00% <ø> (ø)
interceptors/ratelimit/ratelimit.go 60.00% <0.00%> (-40.00%) ⬇️
interceptors/recovery/options.go 78.57% <ø> (ø)
metadata/single_key.go 60.00% <ø> (ø)
testing/testpb/interceptor_suite.go 0.00% <0.00%> (ø)
testing/testpb/test.manual_validator.pb.go 0.00% <0.00%> (ø)
util/backoffutils/backoff.go 60.00% <ø> (ø)
wrappers.go 66.66% <ø> (-33.34%) ⬇️
interceptors/reporter.go 45.45% <20.00%> (-17.05%) ⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83835dc...75eeeba. Read the comment docs.

Copy link
Collaborator

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Amazing. Let's merge and iterate 👍🏽

@bwplotka bwplotka merged commit 58a4066 into grpc-ecosystem:v2 May 5, 2022
@XSAM XSAM deleted the opentracing-provider branch May 6, 2022 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants