Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added logr as logging Library provider #510

Merged
merged 2 commits into from
Aug 30, 2022

Conversation

mcdoker18
Copy link
Contributor

Closes #473
Closes #430

Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, but would love input from @bwplotka.

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2022

Codecov Report

Merging #510 (00c2b32) into v2 (6e2c2ac) will decrease coverage by 25.52%.
The diff coverage is 50.46%.

@@             Coverage Diff             @@
##               v2     #510       +/-   ##
===========================================
- Coverage   84.01%   58.48%   -25.53%     
===========================================
  Files          30       30               
  Lines         932     1573      +641     
===========================================
+ Hits          783      920      +137     
- Misses        110      590      +480     
- Partials       39       63       +24     
Impacted Files Coverage Δ
chain.go 0.00% <ø> (-90.91%) ⬇️
interceptors/auth/auth.go 100.00% <ø> (ø)
interceptors/ratelimit/ratelimit.go 60.00% <0.00%> (-40.00%) ⬇️
interceptors/recovery/options.go 78.57% <ø> (ø)
metadata/single_key.go 60.00% <ø> (ø)
testing/testpb/interceptor_suite.go 0.00% <0.00%> (ø)
testing/testpb/test.manual_validator.pb.go 0.00% <0.00%> (ø)
util/backoffutils/backoff.go 60.00% <ø> (ø)
wrappers.go 66.66% <ø> (-33.34%) ⬇️
interceptors/reporter.go 45.45% <20.00%> (-17.05%) ⬇️
... and 27 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mcdoker18
Copy link
Contributor Author

@johanbrandhorst Can you please help me with the failed linter job?

cannot lint and format files: you have unstaged changes.
M	providers/logr/examples_test.go
M	providers/logr/logger.go
M	providers/logr/logger_test.go
Please commit or stash them.

If it's a flaky job I can't restart it.

@johanbrandhorst
Copy link
Collaborator

I'm guessing it's just a bad error and it's trying to tell us that there was a file formatting diff. Can you try formatting those files?

@mcdoker18
Copy link
Contributor Author

I'm guessing it's just a bad error and it's trying to tell us that there was a file formatting diff. Can you try formatting those files?

Done, thanks!

Copy link
Collaborator

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@bwplotka bwplotka merged commit f3ab992 into grpc-ecosystem:v2 Aug 30, 2022
@bwplotka
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants