-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added logr as logging Library provider #510
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me, but would love input from @bwplotka.
Codecov Report
@@ Coverage Diff @@
## v2 #510 +/- ##
===========================================
- Coverage 84.01% 58.48% -25.53%
===========================================
Files 30 30
Lines 932 1573 +641
===========================================
+ Hits 783 920 +137
- Misses 110 590 +480
- Partials 39 63 +24
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@johanbrandhorst Can you please help me with the failed linter job?
If it's a flaky job I can't restart it. |
I'm guessing it's just a bad error and it's trying to tell us that there was a file formatting diff. Can you try formatting those files? |
Done, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏽
Thanks! |
Closes #473
Closes #430