change the doc.go to the latest format #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 84.01% // Head: 58.74% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## v2 #512 +/- ##
===========================================
- Coverage 84.01% 58.74% -25.27%
===========================================
Files 30 31 +1
Lines 932 1583 +651
===========================================
+ Hits 783 930 +147
- Misses 110 590 +480
- Partials 39 63 +24
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
johanbrandhorst
requested changes
Sep 12, 2022
providers/kit/doc.go
Outdated
| @@ -3,6 +3,7 @@ | |||
|
|
|||
| /* | |||
| `kit` provides a small adapter required to use go-kit/log in logging gRPC middlewares. | |||
| Please see examples for examples of use. | |||
|
|
|||
| Please see examples for examples of use. | |||
There was a problem hiding this comment.
I think this and the other three instances of this change is wrong, can you revert them, please?
aimuz
force-pushed
the
v2-new-doc
branch
2 times, most recently
from
9c6d581
to
6dd6e5b
Compare
Signed-off-by: aimuz <mr.imuz@gmail.com>
johanbrandhorst
approved these changes
Sep 13, 2022
|
Thanks for your contribution! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the result after formatting with gofmt and minor modifications