-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add logging.InjectFields
usage description
#541
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused by this change. Did we remove the tags
interceptor? If so, we should just remove it from the list, not keep it strikethrough.
The implementation of tags has been removed in v2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification, lets just remove this.
README.md
Outdated
@@ -58,7 +56,8 @@ myServer := grpc.NewServer( | |||
|
|||
#### Logging | |||
|
|||
* [`tags`](interceptors/tags) - a library that adds a `Tag` map to context, with data populated from request body | |||
* ~~[`tags`](interceptors/tags) - a library that adds a `Tag` map to context, with data populated from request body.~~ replace `tags.Extract().Set()` to `logging.InjectFields()` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets just remove this line
005a678
to
692a961
Compare
Signed-off-by: aimuz <mr.imuz@gmail.com>
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## v2 #541 +/- ##
===========================================
- Coverage 84.01% 58.74% -25.27%
===========================================
Files 30 31 +1
Lines 932 1583 +651
===========================================
+ Hits 783 930 +147
- Misses 110 590 +480
- Partials 39 63 +24
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Thanks for your contribution! |
Fixed #521