-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2: All for v2: Exemplars, Cleanup, Docs, Lint, Proto upgrades and more #543
Conversation
06bc869
to
507697a
Compare
At least one thing still bothers me before v2:
EDIT: I think I explained all clearly in README, so I would stick to this. Having separate modules in one directory is quite nice. |
f01b009
to
78048fe
Compare
All done and ready for review. |
Signed-off-by: bwplotka <bwplotka@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing default branch to "v2" once v2.0.0 is out, should be fine.
I would prefer that we make a v1
branch off main
and merge v2
into main
instead. That's what we did for the gateway.
Do we have dependabot set up? With this module sprawl we'll want something to manage updates.
I think I addressed all @johanbrandhorst |
Signed-off-by: bwplotka <bwplotka@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this Bartek 🎉
Fixes #347
Fixes #343
Fixes #345
Fixes #483
Fixes #422
Most (if not all) changes for v2.0.0!
Let me know if I need to split into commits for easier review.
TODO: