Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overwritten logger in zerolog example #574

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Fix overwritten logger in zerolog example #574

merged 1 commit into from
Apr 26, 2023

Conversation

longshine
Copy link
Contributor

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Do not overwrite the logger variable outside closure.
Fix #572

Verification

Follow the zerolog example in logging and see if fields in logs are not duplicated as time goes by.

@johanbrandhorst johanbrandhorst merged commit cb96b57 into grpc-ecosystem:main Apr 26, 2023
16 checks passed
@johanbrandhorst
Copy link
Collaborator

Thanks for your contribution!

@longshine longshine deleted the patch-1 branch April 27, 2023 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanbrandhorst johanbrandhorst johanbrandhorst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recursive duplicate fields in logs by zerolog
2 participants
@longshine @johanbrandhorst