Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Client rate limit interceptors 520 #599

Merged
merged 2 commits into from
Jul 7, 2023
Merged

Add Client rate limit interceptors 520 #599

merged 2 commits into from
Jul 7, 2023

Conversation

rahulkhairwar
Copy link
Contributor

@rahulkhairwar rahulkhairwar commented Jul 6, 2023 •
edited

Add Client-side rate limit interceptors

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

  • Added a Unary client-side interceptor
  • Added a Stream client-side interceptor

Verification

  • Added tests to verify the new interceptors work

@rahulkhairwar rahulkhairwar force-pushed the client-rate-limit-interceptors-520 branch from 5e3020c to 004267d Compare July 6, 2023 05:45
johanbrandhorst
johanbrandhorst approved these changes Jul 7, 2023
View reviewed changes
Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johanbrandhorst johanbrandhorst merged commit ca6be73 into grpc-ecosystem:main Jul 7, 2023
6 checks passed
@johanbrandhorst
Copy link
Collaborator

Thanks for your contribution!

@rahulkhairwar rahulkhairwar deleted the client-rate-limit-interceptors-520 branch July 17, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanbrandhorst johanbrandhorst johanbrandhorst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rahulkhairwar @johanbrandhorst