Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Introduce Option Interface for Future Interceptor Customization #615

Conversation

elliotmjackson
Copy link
Contributor

Changes

  • Added an Option interface to provide a mechanism for potential future implementations without breaking existing code.
  • Updated the UnaryServerInterceptor and StreamServerInterceptor functions to accept variadic opts ...Option parameter.
  • Documented the purpose and usage of the Option interface in comments.

Verification

  • Tested the updated code by running unit tests related to the interceptors.
  • Verified that the existing functionality of interceptors remains unchanged.
  • Manually reviewed the code changes for clarity and adherence to best practices.

@google-cla
Copy link

google-cla bot commented Aug 16, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@johanbrandhorst johanbrandhorst merged commit c93f93f into grpc-ecosystem:main Aug 16, 2023
6 checks passed
@johanbrandhorst
Copy link
Collaborator

Thanks for the contribution!

@elliotmjackson elliotmjackson deleted the ejackson/add-interface-space branch August 17, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants