Implement detailed specs of google.api.http #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the data structure in protoc-gen-grpc-gateway/descriptor
yugui
force-pushed
the
feature/google-http-rule-more
branch
from
884f3f7
to
c78916a
Compare
|
It took me some time to figure out what google.api.http is, but it is this: https://github.com/google/googleapis/blob/master/google/api/http.proto |
* Use internal.DoubleArray to reduce time complexity.
* Replace github.com/ajg/form with a custom impl because:
1. proto messages do not have "form" struct tag, thus they does not
fit to the library very well.
2. field paths in google.api.http does not support so complex path
that we need the library.
yugui
changed the title
|
👍 LGTM |
yugui
added a commit
that referenced
this pull request
May 21, 2015
Implement detailed specs of google.api.http
ithinker1991
referenced
this pull request
in tronprotocol/grpc-gateway
Apr 26, 2018
add change getBalance to GetAcconts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR of #12.
It reflects the detailed specs of the new custom option shown by Wolfgang to our implementation.