Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: add a workflow_dispatch trigger for testing #2989

Merged
merged 1 commit into from Nov 3, 2022

Conversation

asraa
Copy link
Contributor

@asraa asraa commented Nov 2, 2022

Signed-off-by: Asra Ali asraa@google.com'

Follow-up to #2987 discussed with @johanbrandhorst

I decided against inputing the release tag in the workflow_dispatch since it's not reproducible anyway. Instead, this will just run on main as a dry-run before pushing any release tags.

References to other Issues or PRs

Have you read the Contributing Guidelines?

Brief description of what is fixed or changed

Other comments

Signed-off-by: Asra Ali <asraa@google.com>
if [[ "$GITHUB_REF" != refs/tags/* ]]; then
args+=' --snapshot'
fi
echo "args=$args" >> $GITHUB_OUTPUT
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for using the new format. Would you mind creating a separate PR to update all our set-output instances the same way? It would be greatly appreciated ❤️.

@johanbrandhorst johanbrandhorst merged commit c2e1a3d into grpc-ecosystem:master Nov 3, 2022
@johanbrandhorst
Copy link
Collaborator

@johanbrandhorst
Copy link
Collaborator

Looks like it worked 🎉

andrewpollock pushed a commit to google/osv.dev that referenced this pull request Nov 28, 2022
)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[github.com/grpc-ecosystem/grpc-gateway/v2](https://togithub.com/grpc-ecosystem/grpc-gateway)
| require | minor | `v2.13.0` -> `v2.14.0` |

---

### Release Notes

<details>
<summary>grpc-ecosystem/grpc-gateway</summary>

###
[`v2.14.0`](https://togithub.com/grpc-ecosystem/grpc-gateway/releases/tag/v2.14.0)

[Compare
Source](https://togithub.com/grpc-ecosystem/grpc-gateway/compare/v2.13.0...v2.14.0)

#### New features

This release contains two significant new OpenAPIv2 generator features,
contributed by [@&#8203;krak3n](https://togithub.com/krak3n):

1. A new option to [disable rendering of 200 OK
responses](https://grpc-ecosystem.github.io/grpc-gateway/docs/mapping/customizing_openapi_output/#disable-default-responses).
This is useful if you define custom responses for your endpoints and you
modify the return code a forward response writer. Note that this does
not change the behavior of the gateway itself.
2. A new annotation for [defining header
parameters](https://grpc-ecosystem.github.io/grpc-gateway/docs/mapping/customizing_openapi_output/#custom-http-header-request-parameters).
This lets to define header parameters you want to be rendered in the
swagger.json output in addition to those defined in your API messages.
Note that this does not change the behavior of the gateway itself and
must be coupled with custom header parsing in your application.

#### What's Changed

- release: Update release.yml with option to workaround SLSA generator
failure by [@&#8203;asraa](https://togithub.com/asraa) in
[grpc-ecosystem/grpc-gateway#2987
- release: add a workflow_dispatch trigger for testing by
[@&#8203;asraa](https://togithub.com/asraa) in
[grpc-ecosystem/grpc-gateway#2989
- Use io/os instread of ioutil and use suitable verb by
[@&#8203;sashamelentyev](https://togithub.com/sashamelentyev) in
[grpc-ecosystem/grpc-gateway#2991
- runtime pkg cleanup by
[@&#8203;sashamelentyev](https://togithub.com/sashamelentyev) in
[grpc-ecosystem/grpc-gateway#2993
- mux: fix path components mutation by
[@&#8203;jonathaningram](https://togithub.com/jonathaningram) in
[grpc-ecosystem/grpc-gateway#3001
- fix: set consumes definition per operation by
[@&#8203;stomy13](https://togithub.com/stomy13) in
[grpc-ecosystem/grpc-gateway#2995
- protoc gen oas v2 cleanup by
[@&#8203;sashamelentyev](https://togithub.com/sashamelentyev) in
[grpc-ecosystem/grpc-gateway#2996
- Use ReplaceAll instead of Replace with -1 pos by
[@&#8203;sashamelentyev](https://togithub.com/sashamelentyev) in
[grpc-ecosystem/grpc-gateway#3003
- Errors cleanup by
[@&#8203;sashamelentyev](https://togithub.com/sashamelentyev) in
[grpc-ecosystem/grpc-gateway#3004
- Cleanup by
[@&#8203;sashamelentyev](https://togithub.com/sashamelentyev) in
[grpc-ecosystem/grpc-gateway#3012
- Support disabling default response rendering by
[@&#8203;krak3n](https://togithub.com/krak3n) in
[grpc-ecosystem/grpc-gateway#3006
- Support request header parameters by
[@&#8203;krak3n](https://togithub.com/krak3n) in
[grpc-ecosystem/grpc-gateway#3010

#### New Contributors

- [@&#8203;asraa](https://togithub.com/asraa) made their first
contribution in
[grpc-ecosystem/grpc-gateway#2987
- [@&#8203;sashamelentyev](https://togithub.com/sashamelentyev) made
their first contribution in
[grpc-ecosystem/grpc-gateway#2991
- [@&#8203;stomy13](https://togithub.com/stomy13) made their first
contribution in
[grpc-ecosystem/grpc-gateway#2995
- [@&#8203;krak3n](https://togithub.com/krak3n) made their first
contribution in
[grpc-ecosystem/grpc-gateway#3006

**Full Changelog**:
grpc-ecosystem/grpc-gateway@v2.13.0...v2.14.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 6am on monday" in timezone
Australia/Sydney, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/google/osv.dev).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4zNy4wIiwidXBkYXRlZEluVmVyIjoiMzQuMzcuMCJ9-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants