Fix 2494

[amanraja]

Fixes #2494

[coderabbitai]

Walkthrough

The changes introduced add a new check in the template to ensure compatibility between path and query parameters. Additionally, updates to the proto file include a oneof_decl named "primary_key" and two new fields, enhancing the service options for HTTP GET requests.

Changes

File	Summary
.../genopenapi/template.go	Introduced a check to prevent conflicting field types from being used together.
.../path_item_object.prototext	Added a oneof_decl named "primary_key", two new fields "uuid" and "id", and additional bindings for HTTP GET requests.

🐇💻

In the land of code, where logic is king,

A rabbit hops forth, changes to bring.

With each line written, with each test run,

The software evolves, the work is done.

So let's celebrate this commit, so neat,

For every bug squashed, is a feat! 🎉🥕

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

• Mention @coderabbitai in any review comment for bot assistance.
• Note: Review comments are made on code diffs or files, not on the PR overview.

Pause Incremental Reviews

• Insert @coderabbitai: ignore in the PR description to halt the bot's ongoing reviews. Remove the line to resume.
• Additionally, enter @coderabbitai pause to halt the bot's ongoing reviews as any issue or review comment. To
  resume reviews, enter @coderabbitai resume as any issue or review comment.

[coderabbitai]

Review Status

Actionable comments generated: 0

Commits

Files that changed from the base of the PR and between d271d84 and b1ee40f.

Files ignored due to filter (1)

• protoc-gen-openapiv2/internal/genopenapi/testdata/generator/path_item_object.swagger.yaml

Files selected for processing (2)

• protoc-gen-openapiv2/internal/genopenapi/template.go (1 hunks)
• protoc-gen-openapiv2/internal/genopenapi/testdata/generator/path_item_object.prototext (2 hunks)

Files skipped from review due to trivial changes (1)

• protoc-gen-openapiv2/internal/genopenapi/template.go

Additional comments (Suppressed): 2

protoc-gen-openapiv2/internal/genopenapi/testdata/generator/path_item_object.prototext (2)

• 14-32: The oneof_decl named "primary_key" and the fields "uuid" and "id" have been added to the message type. Ensure that these changes are reflected in the corresponding service methods and their usage throughout the codebase.

• 40-50: Additional HTTP GET bindings have been added for the fields "value", "uuid", and "id". Make sure that the server-side implementation can handle these new routes correctly, and that they do not conflict with existing routes.

[amanraja]

Hey @johanbrandhorst , Would you please look into this PR ?

[johanbrandhorst]

Hi! Thanks for this PR. The change looks reasonable, but I'm not sure I understand what the testdata changes do. Could you add a test to template_test.go? Or perhaps add an example of this circumstance to one of the test protobuf files and regenerate the files? Thanks!

[amanraja]

Hi! Thanks for this PR. The change looks reasonable, but I'm not sure I understand what the testdata changes do. Could you add a test to template_test.go? Or perhaps add an example of this circumstance to one of the test protobuf files and regenerate the files? Thanks!

Hey @johanbrandhorst , sure i will add tests for template_test.go, i made changes to testdata file to show the issue that we are addressing, hope that would suffice for us ?

[amanraja]

without this fix Id would also come up here, it's not now because uuid is of type one_of