Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bazel): surface --disable_default_responses in rule def #4126

Conversation

rajukrishnamurthy
Copy link
Contributor

References to other Issues or PRs

Fixes #4123

Have you read the Contributing Guidelines? Yes

Brief description of what is fixed or changed

Surfaces the --disable_default_responses flag for the openapi spec generator in the protoc_gen_openapiv2 rule.

Other comments

The --disable_default_responses was implemented in pull/3006

@johanbrandhorst
Copy link
Collaborator

Looks like the bazel check reported a formatting issue, could you take a look?

@rajukrishnamurthy
Copy link
Contributor Author

Looks like the bazel check reported a formatting issue, could you take a look?

yeah sorry, forgot to run buildifier, fixed, however, the http tests are timing out.

@johanbrandhorst
Copy link
Collaborator

Looks like the bazel check reported a formatting issue, could you take a look?

yeah sorry, forgot to run buildifier, fixed, however, the http tests are timing out.

Yeah, no worries, something is going on with the tests, not your fault.

@johanbrandhorst johanbrandhorst merged commit 7e2a7fd into grpc-ecosystem:main Mar 22, 2024
15 of 17 checks passed
@johanbrandhorst
Copy link
Collaborator

Thank you for your contribution!

@rajukrishnamurthy rajukrishnamurthy deleted the feat/disable_default_responses_rule branch March 26, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support disabling default response rendering in bazel rule
2 participants