Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ServerCall.Listener#onComplete for metric collection instead of ServerCall#close #447

Merged
merged 3 commits into from Nov 12, 2020
Merged

Use ServerCall.Listener#onComplete for metric collection instead of ServerCall#close #447

merged 3 commits into from Nov 12, 2020

Conversation

ST-DDT
Copy link
Collaborator

@ST-DDT ST-DDT commented Nov 1, 2020

As documented in grpc/grpc-java#7580, the ServerCall#close might not necessarily be called for cancellations so we should use Listener#onComplete and Listener#onCancel instead.

Closes #438

@ST-DDT ST-DDT added the enhancement A feature request or improvement label Nov 1, 2020
@ST-DDT ST-DDT added this to the 2.11.0 milestone Nov 1, 2020
@ST-DDT ST-DDT requested a review from yidongnan November 1, 2020 17:17
@ST-DDT ST-DDT self-assigned this Nov 1, 2020
yidongnan
yidongnan approved these changes Nov 12, 2020
View reviewed changes
Copy link
Collaborator

@yidongnan yidongnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yidongnan yidongnan merged commit 28d304d into master Nov 12, 2020
@yidongnan yidongnan deleted the metrics/cancellations branch November 12, 2020 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yidongnan yidongnan yidongnan approved these changes

Assignees

@ST-DDT ST-DDT

Labels
enhancement A feature request or improvement
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.

Server processing duration metric not updated for cancellations
2 participants
@ST-DDT @yidongnan