Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example for sleuth and zipkin integration #264 #568

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

haochencheng
Copy link

Hello.I see #264 is marked help wanted .
I add examples:cloud-sleuth-zipkin-grpc-client and examples:cloud-sleuth-zipkin-grpc-server which integration sleuth and
zipkin .

image
image

@ST-DDT
Copy link
Collaborator

ST-DDT commented Aug 3, 2021

Sorry for the late response. I have been on vacation.

This looks good to me. I will do a thorough review in the next few days.

@ST-DDT ST-DDT self-assigned this Aug 3, 2021
@ST-DDT ST-DDT added the examples Everything related to examples label Aug 3, 2021
@ST-DDT
Copy link
Collaborator

ST-DDT commented Aug 3, 2021

Could you please provide a docker command to run the sleuth/zipkin server locally, so that I can run it on my computer without installing sleuth/zipkin there?

@ST-DDT ST-DDT added the feedback required Information are missing or feedback for suggestions is requested label Aug 3, 2021
@haochencheng
Copy link
Author

Could you please provide a docker command to run the sleuth/zipkin server locally, so that I can run it on my computer without installing sleuth/zipkin there?

here is the docker command to install zipkin

docker pull openzipkin/zipkin
docker run --name zipkin -p 9411:9411 openzipkin/zipkin

image

then open http://127.0.0.1:9411/ you could see the zipkin ui
image

@masayoshi-louis
Copy link

I got 2 server spans after adding GrpcSleuthServerConfig.
Called from BloomRPC (a GUI tool for GRPC).

Sorry for my ignorance, but may I ask what's the point of GrpcSleuthServerConfig?
Without it, the tracing also works by just adding brave-instrumentation-grpc dependency.

image

Copy link
Collaborator

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@masayoshi-louis is right. These beans will be created automatically by this library and thus don't need to be created in the example projects again.

@haochencheng Sorry for the delay with my reviews. I'm currently very busy and don't have any spare time.

@haochencheng
Copy link
Author

@masayoshi-louis is right. These beans will be created automatically by this library and thus don't need to be created in the example projects again.

@haochencheng Sorry for the delay with my reviews. I'm currently very busy and don't have any spare time.

It's ok.These beans are redundant,i add these beans want people know that them can customer the beans.The example should by simple and concise. I will do a recheck and remove these benas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Everything related to examples feedback required Information are missing or feedback for suggestions is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants