Add semaphore to limit subchannel connect to prevent race conditions #2422
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2420
I have a theory that concurrent calls to
ConnectTransportAsync
could put a subchannel in a bad state. Two connection requests happen simultaneously but a race condition occurs as they exit.Before:
This PR limits access to connect with a semaphore. A subchannel will have one connect in progress at a time.
After:
Note: New test is unrelated to this exact problem. I wrote it while considering another theory. It's a good test to keep around.