Use contextual serialization #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
changed the title
JamesNK
commented
Jul 9, 2019
| @@ -156,12 +157,18 @@ private static Status CreateUnknownMessageEncodingMessageStatus(string unsupport | |||
| throw new RpcException(CreateUnknownMessageEncodingMessageStatus(grpcEncoding, GrpcProtocolConstants.CompressionProviders.Select(c => c.EncodingName))); | |||
| } | |||
|
|
|||
| #pragma warning disable CS8600 // Converting null literal or possible null value to non-nullable type. | |||
There was a problem hiding this comment.
Nullable attribute isn't working here for some reason. Will clean it up when bug in compiler is fixed. Only effects designer.
|
Awesome. Sorry for bringing you a few hundred lines of work, but I think it moves things in the right direction. Appreciated! |
|
Why are our tests hanging? I'm inclined to to think there's actually something wrong with them now. |
JamesNK
force-pushed
the
jamesnk/contextual-serializers
branch
from
3822541
to
a03b5f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #357
@mgravell