Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xds: server_features should be a child of xds_servers and not a sibling #4087

Merged
merged 2 commits into from Dec 8, 2020
Merged

xds: server_features should be a child of xds_servers and not a sibling #4087

merged 2 commits into from Dec 8, 2020

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Dec 7, 2020

Fixes: #4072

@easwars easwars requested a review from menghanl December 7, 2020 23:54
@easwars easwars added this to the 1.35 Release milestone Dec 7, 2020
@easwars easwars merged commit 96a834a into grpc:master Dec 8, 2020
@easwars easwars deleted the bootstrap_bug branch December 8, 2020 18:27
@ramaraochavali ramaraochavali mentioned this pull request Feb 1, 2021
Merged
This was referenced Mar 8, 2021
Open
Open
Closed
This was referenced Mar 15, 2021
Closed
Closed
Closed
Closed
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@menghanl menghanl menghanl approved these changes

Assignees

@menghanl menghanl

Labels
Type: Bug
Projects
None yet
Milestone
1.35 Release
Development

Successfully merging this pull request may close these issues.

xds: "server_features" field in bootstrap should be a child of "xds_servers" field and not a sibling
2 participants
@easwars @menghanl