update grpc go and remove v2 workarounds #30546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
ramaraochavali
requested review from
costinm,
howardjohn,
linsun,
nmittler and
a team
as code owners
google-cla
bot
added
the
cla: yes
istio-testing
added
the
size/L
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
ramaraochavali
added
the
release-notes-none
|
/test release-notes_istio |
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
ramaraochavali
commented
Feb 1, 2021
| @@ -2,10 +2,10 @@ | |||
| "xds_servers": [ | |||
| { | |||
| "server_uri": "localhost:14057", | |||
| "channel_creds": [{"type": "insecure"}] | |||
| "channel_creds": [{"type": "insecure"}], | |||
| "server_features" : ["xds_v3"] | |||
There was a problem hiding this comment.
This is needed because the new grpc-go expects server_features to be child of xds_servers grpc/grpc-go#4087
|
/test integ-telemetry-mc-k8s-tests_istio |
howardjohn
reviewed
Feb 1, 2021
| @@ -29,6 +29,7 @@ run: | |||
| skip-files: | |||
| - ".*\\.pb\\.go" | |||
| - ".*\\.gen\\.go" | |||
| - pilot/pkg/networking/grpcgen/grpcgen_test.go | |||
There was a problem hiding this comment.
This is to skip import order check. Otherwise we will have to set those env vars in the build file
There was a problem hiding this comment.
oh, thats annoying. Ok, SGTM. I have a bug with GRPC to make this reasonable to configure
| @@ -26,12 +25,16 @@ import ( | |||
| "google.golang.org/grpc/resolver" | |||
| "google.golang.org/grpc/serviceconfig" | |||
|
|
|||
| // To setup the env vars needed for grpc-go. Should be loaded before grpc/xds is loaded. | |||
There was a problem hiding this comment.
is golang initialization order based on import order or something?
There was a problem hiding this comment.
it is based on import ordering
howardjohn
approved these changes
Feb 1, 2021
domcyrus
pushed a commit
to domcyrus/istio
that referenced
this pull request
Feb 4, 2021
* wip Signed-off-by: Rama Chavali <rama.rao@salesforce.com> * fix bootstrap Signed-off-by: Rama Chavali <rama.rao@salesforce.com> * remove unnecessary go.sum change Signed-off-by: Rama Chavali <rama.rao@salesforce.com> * add go.sum change Signed-off-by: Rama Chavali <rama.rao@salesforce.com> * make gen Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the grpc-go to latest released version and removes the workarounds for v2.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[X ] Does not have any changes that may affect Istio users.