server: block GracefulStop on method handlers and make blocking optional for Stop #6922
+177
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6921
This reverts a behavior change in 1.60 for
GracefulStop
.Stop
never blocked for the method handlers, so this would introduce a behavior change forStop
if we did it by default; instead we add aServerOption
to control the behavior.RELEASE NOTES:
GracefulStop
to block until all method handlers return (v1.60 regression); addWaitForHandlers
ServerOption
(experimental) to causeStop
to also block until method handlers return (new feature).