balancer: stop using picker from old balancer when switching balancers #2833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
reviewed
May 24, 2019
balancer_conn_wrappers.go
Outdated
| @@ -151,6 +151,7 @@ func (ccb *ccBalancerWrapper) watcher() { | |||
| for acbw := range scs { | |||
| ccb.cc.removeAddrConn(acbw.getAddrConn(), errConnDrain) | |||
| } | |||
| ccb.UpdateBalancerState(connectivity.TransientFailure, nil) | |||
There was a problem hiding this comment.
Should this be Connecting instead to avoid RPC failures?
There was a problem hiding this comment.
RPCs won't fail when picker is nil, they will block (but then the state and picker are actually inconsistent? Maybe).
I think Connecting is better. Done.
menghanl
force-pushed
the
balancer_switch_picker
branch
from
59ca63b
to
f79fc33
Compare
dfawley
approved these changes
May 28, 2019
dfawley
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates #2731