Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meshca: credentials/sts: PerRPCCreds Implementation #3696

Merged
merged 7 commits into from Jul 9, 2020
Merged

meshca: credentials/sts: PerRPCCreds Implementation #3696

merged 7 commits into from Jul 9, 2020

Commits on Jul 7, 2020

  1. WIP: STS Call Creds Implementation.

    @easwars
    easwars committed Jul 7, 2020
    Copy the full SHA
    53527ee View commit details
    Browse the repository at this point in the history

  2. Add omitempty JSON tags to fields which can be empty.

    @easwars
    easwars committed Jul 7, 2020
    Copy the full SHA
    558fca5 View commit details
    Browse the repository at this point in the history

  3. Use credentials.CheckSecurityLevel().

    @easwars
    easwars committed Jul 7, 2020
    Copy the full SHA
    1053ce5 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2020

  1. Remove code to retry with exponential backoff. 

    Also, refactor the code a bit for easier and better testing.
    @easwars
    easwars committed Jul 8, 2020
    Copy the full SHA
    9e607f5 View commit details
    Browse the repository at this point in the history

  2. http.NewRequestWithContext was only added in go1.13

    @easwars
    easwars committed Jul 8, 2020
    Copy the full SHA
    e02e28e View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2020

  1. Review comments. 

    - Unexport [Request/Response]Parameters structs.
- Hold lock for entire duration of sts request.
- Don't ignore errors on attempts to read actor token.
    @easwars
    easwars committed Jul 9, 2020
    Copy the full SHA
    2482c17 View commit details
    Browse the repository at this point in the history

  2. Cache computed metadata and expiry time instead of raw token.

    @easwars
    easwars committed Jul 9, 2020
    Copy the full SHA
    4378043 View commit details
    Browse the repository at this point in the history