Add some appengine build constraints. #3787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for Go1.9 and appengine was removed in grpc#3767. But it looks like we still need some way to do things differently for certain appengine builds.
dfawley
reviewed
Aug 4, 2020
dfawley
approved these changes
Aug 4, 2020
xds/internal/client/v2/client.go
Outdated
| @@ -54,6 +54,7 @@ func newClient(cc *grpc.ClientConn, opts xdsclient.BuildOptions) (xdsclient.APIC | |||
| nodeProto, ok := opts.NodeProto.(*v2corepb.Node) | |||
| if !ok { | |||
| return nil, fmt.Errorf("xds: unsupported Node proto type: %T, want %T", opts.NodeProto, v2corepb.Node{}) | |||
|
|
|||
menghanl
added a commit
to menghanl/grpc-go
that referenced
this pull request
Aug 27, 2020
)" This reverts commit 5f7b337.
menghanl
added a commit
to menghanl/grpc-go
that referenced
this pull request
Aug 27, 2020
This reverts commit 5f7b337.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for Go1.9 and appengine was removed in #3767. But it looks like we still need some way to do things differently for certain appengine builds.