Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

credentials/alts: ClientAuthorizationCheck to case-fold compare of peer SA #3792

Merged
merged 2 commits into from Sep 1, 2020
Merged

credentials/alts: ClientAuthorizationCheck to case-fold compare of peer SA #3792

merged 2 commits into from Sep 1, 2020

Commits on Aug 5, 2020

  1. ClientAuthorizationCheck ignore-case on SA compare 

    `expectedServiceAccounts` are commonly mixed-case, while the `PeerServiceAccount` is lowel-case.
The discrepancy can be error-prone, recommendation is to use Unicode case-folding comparison.
Nit: change `status.Newf(...).Err()` to the semantically equal `status.Errorf(...)`.
    @AntonNep
    AntonNep committed Aug 5, 2020
    Copy the full SHA
    4a52456 View commit details
    Browse the repository at this point in the history

  2. Update utils_test.go

    @AntonNep
    AntonNep committed Aug 5, 2020
    Copy the full SHA
    3e04e03 View commit details
    Browse the repository at this point in the history