Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stats: include message header in stats.InPayload.WireLength #3886

Merged
merged 2 commits into from Sep 25, 2020
Merged

stats: include message header in stats.InPayload.WireLength #3886

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4d3c2e
Properly report stats.InPayload.WireLength
xstephen95x Sep 18, 2020
2ccc2e4
move +headerLen to the callsite of HandleRPC
xstephen95x Sep 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion rpc_util.go
View file
Open in desktop
Expand Up @@ -636,7 +636,7 @@ func recvAndDecompress(p *parser, s *transport.Stream, dc Decompressor, maxRecei
return nil, err
}
if payInfo != nil {
payInfo.wireLength = len(d)
payInfo.wireLength = len(d) + headerLen
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This field is in sync with payInfo.uncompressedBytes (they both don't include the message header).

Add headerLen when HandleRPC is called?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can do!

}

if st := checkRecvPayload(pf, s.RecvCompress(), compressor != nil || dc != nil); st != nil {
Expand Down