Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pemfile: Move file watcher plugin from advancedtls to gRPC. #3970

Closed
wants to merge 4 commits into from

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Oct 21, 2020

This PR moves the existing PEM file watcher certificate provider plugin from the advancedtls module to gRPC.

The only changes of significance are:

  • Check the contents of the file to see if it has changed before updating distributor.
  • Update the tests.

@easwars
Copy link
Contributor Author

easwars commented Oct 21, 2020

I had done a git mv and initially it was showing as though the file had been branched from its earlier location. But now it shows up as being deleted at the old location and added at the new location :(

@easwars
Copy link
Contributor Author

easwars commented Oct 21, 2020

This is getting a little out of control to rebase with master after #3932. I will close this and reopen a new PR.

@easwars easwars closed this Oct 21, 2020
@easwars easwars deleted the pem_provider branch October 21, 2020 23:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants