xdsclient: populate error details for NACK #3975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easwars
reviewed
Oct 21, 2020
| ) | ||
| switch update := u.(type) { | ||
| case *watchAction: | ||
| target, rType, version, nonce = t.processWatchInfo(update) | ||
| case *ackAction: | ||
| target, rType, version, nonce, send = t.processAckInfo(update, stream) | ||
| target, rType, version, nonce, errMsg, send = t.processAckInfo(update, stream) |
There was a problem hiding this comment.
Why does processAckInfo have to return the errMsg. Why can't we use it directly here? It is available in update.
There was a problem hiding this comment.
Right. This is unnecessary, and processAckInfo cannot change it anyway. Done.
howardjohn
approved these changes
Oct 21, 2020
easwars
approved these changes
Oct 22, 2020
| send bool | ||
| target []string | ||
| rType ResourceType | ||
| version, nonce, errMsg string |
There was a problem hiding this comment.
Nit: We might as well get rid of errMsg and use update.errMsg directly.
There was a problem hiding this comment.
There's a switch: case. Only ackAction has the errMsg field.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3969