Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/transport: fix a bug causing -bin metadata to be incorrectly encoded #3985

Merged
merged 1 commit into from Oct 29, 2020
Merged

internal/transport: fix a bug causing -bin metadata to be incorrectly encoded #3985

merged 1 commit into from Oct 29, 2020

Commits on Oct 25, 2020

  1. internal/transport: fix a bug causing -bin metadata to be incorrectly… 

    … encoded.

Most interfaces for adding metadata to a context downcase keys, except metadata.AppendToOutgoingContext (presumably for performance reasons).  Documentation for metadata.AppendToOutgoingContext, referring to that of metadata.Pairs, states that metadata keys are downcased.

The bug is manifest if you use metadata.AppendToOutgoingContext to add metadata with a non-downcased `-Bin` suffix.  http2Client will not encode such metadata, as encodeMetadataHeader just performs a lower suffix check.
    Nick Jones committed Oct 25, 2020
    Copy the full SHA
    f543946 View commit details
    Browse the repository at this point in the history