tests: refactor tests to use testutils helper functions #5728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvindbr8
commented
Oct 18, 2022
arvindbr8
force-pushed
the
deep-equal-for-error
branch
from
f68e5d4
to
250b421
Compare
arvindbr8
changed the title
easwars
requested changes
Oct 19, 2022
arvindbr8
force-pushed
the
deep-equal-for-error
branch
from
d1f5665
to
0a118f0
Compare
easwars
reviewed
Oct 19, 2022
| return func(p balancer.Picker) error { | ||
| for i := 0; i < rpcCount; i++ { | ||
| if _, err := p.Pick(balancer.PickInfo{}); err == nil || !strings.Contains(err.Error(), want.Error()) { | ||
| return fmt.Errorf("got %q, want error to contain %q, ", want, err) |
There was a problem hiding this comment.
Mention that the error was returned from Pick. See go/go-style/decisions#identify-the-function
return fmt.Errorf("Pick() returned error: %v, want: %v", err, want)We usually use %v as the formatting directive for error types. If you feel strongly about using %q, then I don't mind. But otherwise, it would be better to stick to %v.
Also note that you have for the order or got and want wrong in the arguments list passed to fmt.Error.
There was a problem hiding this comment.
thats a good catch. updating the error message and also flipping the args around
There was a problem hiding this comment.
thanks for catching that. updating this
easwars
approved these changes
Oct 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a reactive from a previous PR (#5711) we want to update certain tests to use helper functions from
internal/testutils/balancer.goRELEASE NOTES: n/a