server: expose API to set send compressor #5744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easwars
requested changes
Nov 18, 2022
jronak
force-pushed
the
set-send-compressor
branch
from
e890733
to
b19a201
Compare
|
@easwars thanks much for the review, I have addressed the comments. Please review when you get a chance |
jronak
force-pushed
the
set-send-compressor
branch
from
4128531
to
e05f066
Compare
easwars
reviewed
Dec 1, 2022
|
This PR is labeled as requiring an update from the reporter, and no update has been received after 6 days. If no update is provided in the next 7 days, this issue will be automatically closed. |
jronak
force-pushed
the
set-send-compressor
branch
from
e05f066
to
8be817f
Compare
jronak
force-pushed
the
set-send-compressor
branch
from
8be817f
to
6d03a48
Compare
dfawley
reviewed
Jan 19, 2023
dfawley
approved these changes
Jan 25, 2023
|
@easwars please take another pass on this after the latest set(s) of changes. |
easwars
approved these changes
Jan 25, 2023
dfawley
requested changes
Jan 27, 2023
dfawley
approved these changes
Jan 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5792
Follow-up of #5541 and #2786
Description:
In the current implementation, the server compresses the send payload when the client sends a compressed request payload or explicitly uses the
grpc.RPCCompressoroption. It cannot be controlled by the user to either use a different compression algorithm or disable compression (identity).This PR exposes an API
grpc.SetSendCompressor(ctx, name)similar to thegrpc.SetHeader(ctx, md), which allows the user to set the compressor to be used for compressing response payload (sent back to the client). The provided compressor is used when the below conditions are met:grpc-accept-encodingmetadata.Other gRPC platforms expose similar APIs, for example grpc-java.
RELEASE NOTES: