Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

peer and metadata: Implement the Stringer interface for Peer and Metadata #7137

Merged
merged 9 commits into from May 6, 2024
Merged

peer and metadata: Implement the Stringer interface for Peer and Metadata #7137

merged 9 commits into from May 6, 2024

Commits on Apr 24, 2024

  1. Satisfy the Stringer interface for Peer and Metadata 

    Effectively allowing to print context containing Peers properly

Also enabling logging of Metadata in an easier way

RELEASE NOTES:

 - peer/peer: implement the Stringer interface for pretty-printing Peers
 - metadata/metadata: implement the Stringer interface for pretty printing metadata

Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
    @AnomalRoil
    AnomalRoil committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    83118ab View commit details
    Browse the repository at this point in the history

  2. Apply code review comment 

    Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
    @AnomalRoil
    AnomalRoil committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    20ee25c View commit details
    Browse the repository at this point in the history

  3. Improve Stringer interface on acBalancerWrapper to allow human identi… 

    …fication of which SubConn is used

Protect access to curAddr with ac.mutex

Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
    @AnomalRoil
    AnomalRoil committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    172603c View commit details
    Browse the repository at this point in the history

  4. Use a strings.Builder in Peer.String with explicit nil fields 

    Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
    @AnomalRoil
    AnomalRoil committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    edfd323 View commit details
    Browse the repository at this point in the history

  5. Revert "Improve Stringer interface on acBalancerWrapper to allow huma… 

    …n identification of which SubConn is used"

This reverts commit 001f394.

Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
    @AnomalRoil
    AnomalRoil committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    985347e View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Addressing code review comments 

    Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
    @AnomalRoil
    AnomalRoil committed May 1, 2024
    Configuration menu
    Copy the full SHA
    067b07e View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Arvind Bright <arvind.bright100@gmail.com>
    @AnomalRoil @arvindbr8
    AnomalRoil and arvindbr8 committed May 2, 2024
    Configuration menu
    Copy the full SHA
    e482bcc View commit details
    Browse the repository at this point in the history

  2. Not doing Peer's security level test 

    Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
    @AnomalRoil
    AnomalRoil committed May 2, 2024
    Configuration menu
    Copy the full SHA
    c908bad View commit details
    Browse the repository at this point in the history

  3. Applying the rest of the code review comments 

    Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
    @AnomalRoil
    AnomalRoil committed May 2, 2024
    Configuration menu
    Copy the full SHA
    d36bfd5 View commit details
    Browse the repository at this point in the history