add: information about endpoint connection when auth handshake fails #7150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are some tests failing which don't correlate with my change. Do I need to do something? |
|
hi @holgerson97 -- I thought I had replied to this PR earlier. Thanks for sending this to us, we think it's definitely useful add some server related info in the log. But we feel like the change could be more wholesome such that all logs in the transport gets it. I am working on a branch to get this functionality. Will get a PR out soon. Closing this PR in that regard. Thanks again for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanted in Kubernetes: kubernetes/kubernetes#122639
It adds more information to the log when the authentication handshake fails in gRPC connections.