advancedtls: fix docstring for VerificationResults #7168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjan-bal
force-pushed
the
fix-static-check
branch
2 times, most recently
from
5d09a28
to
3f9f427
Compare
purnesh42H
reviewed
Apr 24, 2024
| @@ -67,6 +67,9 @@ type VerificationFuncParams = HandshakeVerificationInfo | |||
| // future to include more information. | |||
| type PostHandshakeVerificationResults struct{} | |||
|
|
|||
| // VerificationResults contains the information about results of | |||
| // CustomVerificationFunc. | |||
There was a problem hiding this comment.
is this moved to new line by auto formatter?
There was a problem hiding this comment.
I think so, it was the same earlier:
grpc-go/security/advancedtls/advancedtls.go
Lines 57 to 59 in 5fe2e74
There was a problem hiding this comment.
So what's the fix here, how come tests are passed now?
purnesh42H
approved these changes
Apr 24, 2024
arjan-bal
force-pushed
the
fix-static-check
branch
from
3f9f427
to
ff5b041
Compare
arjan-bal
force-pushed
the
fix-static-check
branch
from
ff5b041
to
1596874
Compare
|
I think this fix is also part of this PR https://github.com/grpc/grpc-go/pull/7151/files |
I see. @gtcooke94, will #7151 be merged soon? If not, should we fix only the lint error to make the tests healthy again? |
|
@dfawley PTAL and merge if it looks good. I can't merge since I don't have write access. |
dfawley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The static checks enabled in #7155 are failing due #7140 being merged around the same time. #7140 removed the doc string for VerificationResults and replaced it with a deprecation note. As a result the static check failed with the following error:
Example failure: https://github.com/grpc/grpc-go/actions/runs/8811877128/job/24186556563?pr=7163
This change brings back the first line of the doc string to satisfy the test.
RELEASE NOTES: none