Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: implement maxAttempts for retryPolicy #7223

Closed
wants to merge 1 commit into from

Conversation

imoore76
Copy link

@imoore76 imoore76 commented May 10, 2024

Addresses #4615

RELEASE NOTES: none

Copy link

linux-foundation-easycla bot commented May 10, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: imoore76 / name: Ian Moore (d6cf947)

@imoore76 imoore76 force-pushed the max_attempts branch 2 times, most recently from e72999b to cab3751 Compare May 11, 2024 13:30
Copy link

codecov bot commented May 11, 2024

Codecov Report

Attention: Patch coverage is 73.91304% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 80.56%. Comparing base (adf976b) to head (cab3751).
Report is 51 commits behind head on master.

❗ Current head cab3751 differs from pull request most recent head d6cf947. Consider uploading reports for the commit d6cf947 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7223      +/-   ##
==========================================
- Coverage   81.24%   80.56%   -0.68%     
==========================================
  Files         345      349       +4     
  Lines       33941    34057     +116     
==========================================
- Hits        27574    27439     -135     
- Misses       5202     5427     +225     
- Partials     1165     1191      +26     
Files Coverage Δ
dialoptions.go 89.38% <100.00%> (+0.22%) ⬆️
service_config.go 80.98% <ø> (+1.93%) ⬆️
clientconn.go 92.29% <66.66%> (+1.52%) ⬆️
stream.go 81.30% <25.00%> (-0.18%) ⬇️

... and 32 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant