Skip to content

Commit

Permalink
Fix errorprone requireUpperBoundDeps failure due to protobuf-java-util
Browse files Browse the repository at this point in the history
The changes didn't introduce a bug. It is just we previously excluded
and re-defined errorprone with guava such that it would be closer to the
root and ended up beating protobuf-java-util's dep.
  • Loading branch information
ejona86 committed Jun 5, 2021
1 parent b009b0b commit a71bf2d
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
5 changes: 0 additions & 5 deletions examples/example-gauth/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,6 @@
<groupId>io.grpc</groupId>
<artifactId>grpc-auth</artifactId>
</dependency>
<dependency>
<groupId>com.google.protobuf</groupId>
<artifactId>protobuf-java-util</artifactId>
<version>${protobuf.version}</version>
</dependency>
<dependency>
<groupId>org.apache.tomcat</groupId>
<artifactId>annotations-api</artifactId>
Expand Down
6 changes: 6 additions & 0 deletions examples/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,12 @@
<artifactId>protobuf-java-util</artifactId>
<version>${protobuf.version}</version>
</dependency>
<!-- Override protobuf-java-util's older error prone for requireUpperBoundDeps -->
<dependency>
<groupId>com.google.errorprone</groupId>
<artifactId>error_prone_annotations</artifactId>
<version>2.4.0</version>
</dependency>
<dependency>
<groupId>org.apache.tomcat</groupId>
<artifactId>annotations-api</artifactId>
Expand Down

0 comments on commit a71bf2d

Please sign in to comment.