Skip to content

Commit

Permalink
Stabilize forwarding builders (#10586)
Browse files Browse the repository at this point in the history
- `ForwardingServerBuilder`
- `ForwardingChannelBuilder` - will be deprecated immidiatelly after
   stabilization
- `ForwardingChannelBuilder2` - should be used instead of
  `ForwardingChannelBuilder`
  • Loading branch information
sergiitk committed Oct 6, 2023
1 parent 8a247ad commit ab8210a
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 5 deletions.
4 changes: 1 addition & 3 deletions api/src/main/java/io/grpc/ForwardingChannelBuilder.java
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
* @param <T> The type of the subclass extending this abstract class.
* @since 1.7.0
*/
@ExperimentalApi("https://github.com/grpc/grpc-java/issues/3363")
public abstract class ForwardingChannelBuilder<T extends ForwardingChannelBuilder<T>>
extends ForwardingChannelBuilder2<T> {
// TODO(sergiitk): deprecate after stabilizing
Expand Down Expand Up @@ -237,8 +236,7 @@ public T disableServiceConfigLookUp() {
/**
* Returns the correctly typed version of the builder.
*/
protected final T thisT() {
// TODO(sergiitk): make private when stabilizing.
private T thisT() {
@SuppressWarnings("unchecked")
T thisT = (T) this;
return thisT;
Expand Down
1 change: 0 additions & 1 deletion api/src/main/java/io/grpc/ForwardingChannelBuilder2.java
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
* @param <T> The type of the subclass extending this abstract class.
* @since 1.59.0
*/
@ExperimentalApi("https://github.com/grpc/grpc-java/issues/10585")
public abstract class ForwardingChannelBuilder2<T extends ManagedChannelBuilder<T>>
extends ManagedChannelBuilder<T> {

Expand Down
1 change: 0 additions & 1 deletion api/src/main/java/io/grpc/ForwardingServerBuilder.java
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
* @param <T> The type of the subclass extending this abstract class.
* @since 1.34.0
*/
@ExperimentalApi("https://github.com/grpc/grpc-java/issues/7393")
public abstract class ForwardingServerBuilder<T extends ServerBuilder<T>> extends ServerBuilder<T> {

/** The default constructor. */
Expand Down

0 comments on commit ab8210a

Please sign in to comment.