Skip to content

Commit

Permalink
xds: disable processing of UpstreamTlsContext in 1.30.x release branch (
Browse files Browse the repository at this point in the history
  • Loading branch information
sanjaypujare committed Jun 22, 2020
1 parent adb0ba4 commit dce154f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 3 additions & 1 deletion xds/src/main/java/io/grpc/xds/CdsLoadBalancer.java
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,9 @@ public void onClusterChanged(ClusterUpdate newUpdate) {
/* edsServiceName = */ newUpdate.getEdsServiceName(),
/* lrsServerName = */ newUpdate.getLrsServerName(),
new PolicySelection(lbProvider, ImmutableMap.<String, Object>of(), lbConfig));
updateSslContextProvider(newUpdate.getUpstreamTlsContext());
if (false) {
updateSslContextProvider(newUpdate.getUpstreamTlsContext());
}
if (edsBalancer == null) {
edsBalancer = lbRegistry.getProvider(EDS_POLICY_NAME).newLoadBalancer(helper);
}
Expand Down
2 changes: 2 additions & 0 deletions xds/src/test/java/io/grpc/xds/CdsLoadBalancerTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@
import java.util.List;
import java.util.Map;
import org.junit.Before;
import org.junit.Ignore;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.JUnit4;
Expand Down Expand Up @@ -338,6 +339,7 @@ public void handleCdsConfigUpdate() {
assertThat(xdsClientPool.xdsClient).isNull();
}

@Ignore
@Test
@SuppressWarnings({"unchecked"})
public void handleCdsConfigUpdate_withUpstreamTlsContext() {
Expand Down

0 comments on commit dce154f

Please sign in to comment.